Skip to content

Baro Bugfixes - #71

Open
AnSq wants to merge 2 commits into
warframe-tools:mainfrom
AnSq:bugfixes
Open

Baro Bugfixes#71
AnSq wants to merge 2 commits into
warframe-tools:mainfrom
AnSq:bugfixes

Conversation

@AnSq

@AnSq AnSq commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

AI Disclosure:

  • I did not use AI for anything in this pull request.
  • I did use AI in this pull request, and I have included a statement of AI use in the commit message of every commit where I used AI.

Here's the bugfixes factored out of #69 as discussed. You can merge either this or #69 first, and I'll fix the resulting merge conflicts with the other one.

Bug Fixes

  • Baro's "leaving soon" notification works again (both PRs contain this bugfix).
  • Baro now becomes locked when becoming unavailable while not checked.
  • Baro now becomes unlocked when becoming available without needing a refresh.
  • Fixed tasks with cycle schedules that observe DST (only Baro) not showing the correct current offering when they reset when DST is active.
  • v5.3.1 (both this and #69 are 5.3.1. Whichever one merges 2nd, I'll change to 5.3.2 when I resolve the merge conflicts).

Code Stuff

  • Renamed "cycle number" to "reset count" because it doesn't actually have anything to do with the cycle schedule feature and that's confusing.
  • All daily and weekly tasks are now prepped with a period, not just alternate ref ones.
  • New fixTimeTravel function to aid with debugging.
  • Removed some task definition error checking in the app because it's already validated in test cases.
  • Added test to validate cycle refs.

AnSq added 2 commits August 10, 2026 09:03
* "leaving soon" notification works again
* now becomes locked when becoming unavailable while not checked
* now becomes unlocked when becoming available without needing a refresh
* v5.3.1
Fixed tasks with cycle schedules that observe DST (only Baro) not showing the correct current offering when they reset when DST is active.

* renamed "cycle number" to "reset count" because it doesn't have anything to do with the cycle schedule feature and that's confusing
* all daily and weekly tasks are now prepped with a period, not just alternate ref ones
* new `fixTimeTravel` function to aid with debugging
* removed some error checking for stuff that's checked in tests
* added test to validate cycle refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant